Go/Java: fix miscellaneous trivial issues highlighted by ql-for-ql #20931
+20
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses trivial code quality issues identified by ql-for-ql analysis, focusing on removing redundant code, improving documentation, and standardizing formatting.
- Removes redundant code constructs (unused imports, unnecessary exists clauses, and redundant constructors)
- Renames a predicate in experimental code to follow QL naming conventions
- Improves comment clarity and formatting consistency in query metadata
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
go/ql/test/library-tests/semmle/go/dataflow/GlobalVariableSideEffects/Flows.ql |
Removes redundant exists(src) and clause that serves no purpose |
go/ql/src/experimental/frameworks/DecompressionBombsCustomizations.qll |
Updates comment to be more concise and accurate for the class description |
go/ql/src/experimental/CWE-918/validator.qll |
Renames predicate from getTagByKeyValue to hasTagKeyValue to follow QL naming conventions |
go/ql/src/Security/CWE-020/UntrustedDataToUnknownExternalAPI.ql |
Splits tags metadata onto separate lines for better formatting |
go/ql/src/Security/CWE-020/UntrustedDataToExternalAPI.ql |
Splits tags metadata onto separate lines for better formatting |
go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll |
Removes unused private import of Private module |
go/ql/lib/semmle/go/dataflow/GlobalValueNumbering.qll |
Removes redundant constructor that adds no value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aschackmull
approved these changes
Nov 28, 2025
owen-mc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All trivial changes, except one renaming of a predicate, but it's in experimental so we don't expect anyone to be relying on it.